-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add our environments #7
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify the version when cloning Change-Id: I83e9f57c9ad698c2e64cea8193d0afb100338659
Change-Id: I49f31840d941348f7410d8fa52262ea06f396212
…b100338659 Improve Irrlicht instructions
…a06f396212 clang-format filesys
* Create the temp file in a temp directory. That way the OS should delete it in case this code does not manage to. * Increase the amount of time between attempts to move the file. * After all attempts fail, fall back to copying. The deletion of the source temporary file may fail for the same reason that MoveFileEx failed, but the OS should clean it up eventually. Also add a test for it. It seemed some things in the `fs` namespace were already tested in test_filepath, so I renamed that to test_filesys and added the test there. Change-Id: Idb817c3b41c7f4c81805f937e6bf467d85a4f124
…7d85a4f124 Make safeWriteToFile more likely to succeed on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.