Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add our environments #7

Closed
wants to merge 24 commits into from
Closed

Add our environments #7

wants to merge 24 commits into from

Conversation

jedmccaleb
Copy link
Contributor

No description provided.

garymm and others added 17 commits November 28, 2023 16:24
Specify the version when cloning

Change-Id: I83e9f57c9ad698c2e64cea8193d0afb100338659
Change-Id: I49f31840d941348f7410d8fa52262ea06f396212
…b100338659

Improve Irrlicht instructions
* Create the temp file in a temp directory. That way the OS should
  delete it in case this code does not manage to.
* Increase the amount of time between attempts to move the file.
* After all attempts fail, fall back to copying. The deletion of the
  source temporary file may fail for the same reason that MoveFileEx
  failed, but the OS should clean it up eventually.

Also add a test for it. It seemed some things in the `fs` namespace
were already tested in test_filepath, so I renamed that to test_filesys
and added the test there.

Change-Id: Idb817c3b41c7f4c81805f937e6bf467d85a4f124
…7d85a4f124

Make safeWriteToFile more likely to succeed on Windows.
@jedmccaleb jedmccaleb closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants